Herbalife has a considerable catalogue of products, so I am not certain about which products you are asking. In general, I suspect their products are safe. They are a large enough company that the FDA would assuredly take action were there issues with safety. As for effective, that is hard to answer. Theoretically every dietary supplement has a purpose. In the case of essential nutrients like vitamins and minerals, if the diet does not provide sufficient levels, then supplementation can make a difference. The form, amount, dosing and delivery of a product can all make a difference in how it will work in the body of the user. When evaluating any manufacturer’s products, look for easy-to-find label information and research/references that support the use and amounts in the product, not just testimonials.